Messages in this thread | | | Date | Thu, 5 Jan 2012 17:56:53 -0800 | From | Christopher Heiny <> | Subject | Re: [RFC PATCH 2/11] input: RMI4 core bus and sensor drivers. |
| |
Hi Shubhrajyoti,
Thanks for the feedback. Please see my comments below.
On 01/01/2012 10:38 PM, Shubhrajyoti wrote: > Hi Christopher, > > On Thursday 22 December 2011 07:39 AM, Christopher Heiny wrote: >> Signed-off-by: Christopher Heiny<cheiny@synaptics.com> >> >> Cc: Dmitry Torokhov<dmitry.torokhov@gmail.com> >> Cc: Linus Walleij<linus.walleij@stericsson.com> >> Cc: Naveen Kumar Gaddipati<naveen.gaddipati@stericsson.com> >> Cc: Joeri de Gram<j.de.gram@gmail.com> >> >> --- >> >> drivers/input/rmi4/rmi_bus.c | 436 ++++++++++++ >> drivers/input/rmi4/rmi_driver.c | 1488 +++++++++++++++++++++++++++++++++++++++ >> drivers/input/rmi4/rmi_driver.h | 97 +++ >> 3 files changed, 2021 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
[snip]
>> +#ifdef CONFIG_PM >> +static int rmi_bus_suspend(struct device *dev) >> +{ >> +#ifdef GENERIC_SUBSYS_PM_OPS >> + const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL; >> + >> + if (pm&& pm->suspend) >> + return pm->suspend(dev); > If driver-pm- suspend is not there should you not fall back to . suspend ?
I'm looking into using dev->driver->suspend() here. It wants a pm_message_t for the pm state. We don't have that on entry to bus_suspend, though. Any suggestion as to what we should pass?
Thanks, Chris
| |