Messages in this thread | | | Date | Thu, 5 Jan 2012 09:49:19 -0800 | Subject | Re: [PATCH 1/5] x86: efi: refactor efi_init() a bit | From | Olof Johansson <> |
| |
On Thu, Jan 5, 2012 at 3:22 AM, Matt Fleming <matt.fleming@intel.com> wrote: > On Tue, 2012-01-03 at 09:11 -0800, Olof Johansson wrote: >> Break out some of the init steps into helper functions. >> >> No code changes at all, identical execution flow. >> >> Signed-off-by: Olof Johansson <olof@lixom.net> >> --- >> arch/x86/platform/efi/efi.c | 89 +++++++++++++++++++++++++++---------------- >> 1 files changed, 56 insertions(+), 33 deletions(-) > > Makes sense. I've got one tiny comment below, but other than that feel > free to add, > > Acked-by: Matt Fleming <matt.fleming@intel.com> > >> if (memmap.desc_size != sizeof(efi_memory_desc_t)) >> - printk(KERN_WARNING >> - "Kernel-defined memdesc doesn't match the one from EFI!\n"); >> + printk(KERN_WARNING "Kernel-defined memdesc doesn't match the " >> + "one from EFI!\n"); > > This sort of thing is generally discouraged because splitting a printk > string across more than one line makes it harder to grep for. I'm not > sure this hunk is an improvement.
Agreed, and in this particular case it was just churn.
I've taken a couple of liberties with the 80-character limit instead in the revised patch set. For the ones that would go way above 80 I still broke them in two lines though.
Thanks,
-Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |