lkml.org 
[lkml]   [2012]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] input: Synaptics USB device driver
On Tue, 3 Jan 2012, Jan Steinhoff wrote:

[ ... snip ... ]
> +static int synusb_setup_iurb(struct synusb *synusb,
> + struct usb_endpoint_descriptor *endpoint)
> +{
> + char *buf;
> +
> + if (endpoint->wMaxPacketSize < 8)
> + return 0;
> + if (synusb->iurb) {
> + synusb_warn(synusb, "Found more than one possible "
> + "int in endpoint");
> + return 0;
> + }
> + synusb->iurb = usb_alloc_urb(0, GFP_KERNEL);
> + if (synusb->iurb == NULL)
> + return -ENOMEM;
> + buf = usb_alloc_coherent(synusb->udev, 8, GFP_ATOMIC,
> + &synusb->iurb->transfer_dma);
> + if (buf == NULL)
> + return -ENOMEM;

You seem to leak synusb->iurb here.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2012-01-04 09:57    [W:0.047 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site