Messages in this thread | | | Date | Wed, 4 Jan 2012 09:46:11 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 1/2] memcg: root_mem_cgroup makes static |
| |
On Tue 03-01-12 18:33:51, kosaki.motohiro@gmail.com wrote: > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > root_mem_cgroup is only referenced from memcontrol.c. It should be static.
This has been already posted by Kirill https://lkml.org/lkml/2011/12/23/292
> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@suse.cz>, > Cc: cgroups@vger.kernel.org > --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 90fdaeb..6adeeec 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -59,7 +59,7 @@ > > struct cgroup_subsys mem_cgroup_subsys __read_mostly; > #define MEM_CGROUP_RECLAIM_RETRIES 5 > -struct mem_cgroup *root_mem_cgroup __read_mostly; > +static struct mem_cgroup *root_mem_cgroup __read_mostly; > > #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP > /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |