Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) | Date | Thu, 05 Jan 2012 10:33:53 +1030 |
| |
On Wed, 04 Jan 2012 09:12:18 +0200, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: Non-text part: multipart/signed > Hi, > > On Thu, 2011-12-15 at 13:48 +1030, Rusty Russell wrote: > > module_param(bool) used to counter-intuitively take an int. In > > fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy > > trick. > > > > It's time to remove the int/unsigned int option. For this version > > it'll simply give a warning, but it'll break next kernel version. > > > > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > > The changes below break compilation for omapdss and omapfb: dss_debug > and omapfb_debug are declared in dss.h and omapfb.h, and those > declarations are not changed, resulting in conflicting types error. > > Perhaps extra care should be taken in cases where the variable in > question is not declared as static.
Yes, after the first few hours I got lazy. Obviously, linux-next doesn't build with CONFIG_OMAP2_DSS_DEBUG_SUPPORT (or may not build OSS2 at all), so it didn't catch them either.
I've fixed it (probably tomorrow's linux-next), but hope that the introduction of a 'bool' in that header doesn't break anything else.
Please post fix if it does. Though I think the new hotness is dev_debug and dynamic debugging.
Thanks! Rusty.
| |