Messages in this thread | | | Date | Wed, 4 Jan 2012 16:07:52 -0500 | From | Paul Gortmaker <> | Subject | Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/ |
| |
On 12-01-04 03:51 PM, Greg KH wrote: > On Wed, Jan 04, 2012 at 09:34:36PM +0100, Jiri Slaby wrote: >> On 01/04/2012 09:01 PM, Paul Gortmaker wrote: >>> rename drivers/tty/{ => serial}/amiserial.c (100%) >>> rename drivers/tty/{ => serial}/cyclades.c (100%) >>> rename drivers/tty/{ => serial}/isicom.c (100%) >>> rename drivers/tty/{ => serial}/moxa.c (100%) >>> rename drivers/tty/{ => serial}/moxa.h (100%) >>> rename drivers/tty/{ => serial}/mxser.c (100%) >>> rename drivers/tty/{ => serial}/mxser.h (100%) >>> rename drivers/tty/{ => serial}/rocket.c (100%) >>> rename drivers/tty/{ => serial}/rocket.h (100%) >>> rename drivers/tty/{ => serial}/rocket_int.h (100%) >>> rename drivers/tty/{ => serial}/synclink.c (100%) >>> rename drivers/tty/{ => serial}/synclink_gt.c (100%) >>> rename drivers/tty/{ => serial}/synclinkmp.c (100%) >> >> Hmm, tty/serial/* used to be for those using serial-core. And tty/ for >> those who don't. But FWIW I don't mind the change. > > Yes, that is what I used when splitting them up, so this patch doesn't > make much sense. > > Paul, why do you want these all mixed together?
My thinking was that having a drivers/tty/serial dir and then not having all the serial drivers in that dir violated the principle of least surprise. Is there a reason why the dir should be the exclusive domain of drivers with a dependency on SERIAL_CORE?
Paul.
> > greg k-h
| |