Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter | Date | Wed, 01 Feb 2012 12:59:38 +1030 |
| |
On Tue, 31 Jan 2012 14:45:18 +0100, Danny Kukawka <danny.kukawka@bisect.de> wrote: > On Dienstag, 31. Januar 2012, Andy Walls wrote: > Overseen this. But wouldn't be the correct fix in this case to: > a) reverse the part of 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to: > get: > static unsigned radio_c = 1; > > b) change the following line: > module_param_array(radio, bool, &radio_c, 0644); > to: > module_param_array(radio, int, &radio_c, 0644);
Yes, sorry, my patch was complete crap here :(
If you want people to set it only to 1 or 0, you probably want "bint".
Thanks, Rusty.
| |