lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rtlwifi/rtl8192c: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
From
Date
On Tue, 2012-01-31 at 02:11 -0500, Devendra.Naga wrote:
> From: "Devendra.Naga" <devendra.aaru@gmail.com>
[]
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c
[]
> @@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask)
> u32 i;
>
> for (i = 0; i <= 31; i++) {
> - if (((bitmask >> i) & 0x1) == 1)
> + if ((bitmask >> i) & 0x1)
> break;
> }
> return i;

Perhaps this is simpler and faster:

{
u32 rtn = (u32)ffs((int)bitmask);
if (rtn)
return rtn - 1;
return 32;
}




\
 
 \ /
  Last update: 2012-01-31 08:39    [W:0.033 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site