lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] perf tools: More fixes and updates
On 15.12.11 17:32:38, Robert Richter wrote:
> Some more fixes and updates for perf tools.
>
> Robert Richter (4):
> perf tools: Fix uninitialized memory access to struct perf_sample
> perf record: Make feature initialization generic
> perf tools: Moving code in header.c
> perf tools: Factor out feature op to process header sections

Arnaldo,

have you had the time to look at patches 2-4? They refactor the code
without changing functionality, but makes implementation easier and
more maintainable.

Thanks,

-Robert

>
> tools/perf/builtin-record.c | 28 +---
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/header.c | 344 ++++++++++++++++++++++---------------------
> tools/perf/util/header.h | 1 +
> 4 files changed, 190 insertions(+), 185 deletions(-)
>
> --
> 1.7.7
>

--
Advanced Micro Devices, Inc.
Operating System Research Center



\
 
 \ /
  Last update: 2012-01-31 16:55    [W:0.422 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site