lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix readahead pipeline break caused by block plug
On Tue, Jan 31, 2012 at 06:34:52AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 31, 2012 at 06:57:54PM +0800, Wu Fengguang wrote:
> > The problem is, there are a dozen of ->direct_IO callback functions.
> > While there are only two ->direct_IO() callers, one for READ and
> > another for WRITE, which are much easier to deal with.
>
> So what? Better do a bit more work now and keep the damn thing
> maintainable.

What if we add a wrapper function for doing

blk_start_plug(&plug);
->direct_IO()
blk_finish_plug(&plug);

Thanks,
Fengguang


\
 
 \ /
  Last update: 2012-01-31 12:57    [W:0.038 / U:1.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site