Messages in this thread | | | Date | Tue, 31 Jan 2012 05:46:21 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH] fix readahead pipeline break caused by block plug |
| |
On Tue, Jan 31, 2012 at 06:34:16PM +0800, Wu Fengguang wrote: > } > > + blk_start_plug(&plug); > written = mapping->a_ops->direct_IO(WRITE, iocb, iov, pos, *nr_segs); > + blk_finish_plug(&plug);
Please move the plugging into ->direct_IO for both read and write, as that is the boundary between generic highlevel code, and low-level block code that should know about plugs.
| |