Messages in this thread | | | Date | Tue, 31 Jan 2012 01:22:22 -0500 | Subject | Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req | From | "devendra.aaru" <> |
| |
On Mon, Jan 30, 2012 at 6:45 PM, Joe Perches <joe@perches.com> wrote: > On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote: >> The patch is OK, but the patch subject is bad. You should have "[PATCH] >> rtlwifi:...". Your patch is for rtlwifi, not wireless. > Will post a new patch, Thanks !! > Hi Devendra. > > A reasonable rule of thumb is use the deepest directory > path basename you can to prefix the patch. > Something like: > > [PATCH] $(basename $(dirname $file)): terse description > > If you are patching drivers/net/ethernet/realtek/apt.c > this becomes: > > [PATCH] realtek: terse description > > There are some exceptions though. One of them > is if the patch is in staging, prefix with > [PATCH] staging: $(basename $(dirname $file)): description > > cheers, Joe > Thanks a lot Joe, will follow your suggestions :).
Devendra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |