Messages in this thread | | | Date | Mon, 30 Jan 2012 16:12:46 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH v2 2/4] PM/Freezer: Make thaw_processes() thaw only userspace tasks |
| |
Hello,
On Tue, Jan 31, 2012 at 05:39:00AM +0530, Srivatsa S. Bhat wrote: > The thing is that, I wanted to avoid a bug in the patch posted at > https://lkml.org/lkml/2012/1/29/47 as explained in the link. > > So I guess I should have simply done: > > freeze_kernel_threads() calls thaw_kernel_threads() upon error. > The caller of freeze_kernel_threads() will call thaw_processes() if > necessary. > > This way even the SNAPSHOT_CREATE_IMAGE ioctl would remain safe.
Yeah, I'd prefer to avoid exporting "userland only" interface to outside. If it's some internal fail path thing, let's handle it inside pm proper.
Thanks.
-- tejun
| |