Messages in this thread Patch in this message | | | Date | Mon, 30 Jan 2012 05:20:51 -0800 | From | tip-bot for Dan Carpenter <> | Subject | [tip:perf/urgent] x86/dumpstack: Remove unneeded check in dump_trace() |
| |
Commit-ID: d0caf292505d051b1026e85faf3a85e907566f31 Gitweb: http://git.kernel.org/tip/d0caf292505d051b1026e85faf3a85e907566f31 Author: Dan Carpenter <dan.carpenter@oracle.com> AuthorDate: Sat, 28 Jan 2012 13:52:46 +0300 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Sat, 28 Jan 2012 13:09:06 +0100
x86/dumpstack: Remove unneeded check in dump_trace()
Smatch complains that we have some inconsistent NULL checking.
If "task" were NULL then it would lead to a NULL dereference later. We can remove this test because earlier on in the function we have:
if (!task) task = current;
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Clemens Ladisch <clemens@ladisch.de> Link: http://lkml.kernel.org/r/20120128105246.GA25092@elgon.mountain Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/kernel/dumpstack_64.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c index 6d728d9..af7785f 100644 --- a/arch/x86/kernel/dumpstack_64.c +++ b/arch/x86/kernel/dumpstack_64.c @@ -129,7 +129,7 @@ void dump_trace(struct task_struct *task, struct pt_regs *regs, if (!stack) { if (regs) stack = (unsigned long *)regs->sp; - else if (task && task != current) + else if (task != current) stack = (unsigned long *)task->thread.sp; else stack = &dummy;
| |