lkml.org 
[lkml]   [2012]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs tunable
* Peter Zijlstra <a.p.zijlstra@chello.nl> [2012-01-25 15:57:26]:

> On Mon, 2012-01-16 at 21:52 +0530, Vaidyanathan Srinivasan wrote:
> > +enum powersavings_level {
> > + POWERSAVINGS_DISABLED = 0, /* Max performance */
> > + POWERSAVINGS_DEFAULT, /* Kernel default policy, automatic powersave */
> > + /* vs performance tradeoff */
> > + POWERSAVINGS_MAX /* Favour power savings over peformance */
> > };
>
> I don't like that, I can get, OFF, AUTO, ON, but to overload that with
> different policies for AUTO and ON just reeks.

How about this:

enum powersavings_level {
POWERSAVINGS_OFF = 0, /* Max performance */
POWERSAVINGS_AUTO, /* Kernel default policy, automatic powersave */
/* vs performance tradeoff */
POWERSAVINGS_ON /* Max power savings */
};

Basically AUTO is where we have a 'policy' or heuristics, but simple
straight forward decisions for OFF and ON case.

--Vaidy



\
 
 \ /
  Last update: 2012-01-27 10:19    [W:0.065 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site