Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7 | Date | Fri, 27 Jan 2012 12:55:50 -0800 |
| |
Andi Kleen <andi@firstfloor.org> writes:
>> > The basic problem is if this interface is at the right level of abstraction. >> > I have some doubts on that. It seems like a long term maintenance nightmare to >> > me. It may be better to put the loop that would call this into the kernel. >> > >> >> Hmm, ie selftest right in kenel? > > Not testing, but more the general stability of the interface. IMHO it exposes > too many kernel internals. I know they are already exposed by clone/unshare, > but in those nothing breaks if the user program doesn't know about some new > flags. But this looks like the user always has to be updated for every change. > I think I would prefer if more of the user was in kernel to not expose > that much.
Do you vote for putting the entire process serializer in one system call then?
With the serializer in userspace you only need to update your userspace code if something uses a new facility. Which is the standard userspace requirement. Userspace does not need to be strictly in sync with the kernel.
Personally I think all of this exporting extra state a little at a time is horrible, but it seems to have a better chance of getting merged because the pain comes a little at time.
Eric
| |