lkml.org 
[lkml]   [2012]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface
From
Date
On Fri, 2012-01-27 at 17:54 +0100, Jiri Olsa wrote:

> yay.. ok :) so this one is triggered only if there's CONFIG_DEBUG_PREEMPT
> option enabled.. seems to me it'd better to keep the implicit check anyway.

If the per_cpu pointer usage already warns if preemption is not
disabled, then we don't need the extra check. I think I was the one to
recommend adding it, but if the warning is already there, I don't think
it is necessary. You can still keep a comment, and even say, the per_cpu
pointer usage will complain when CONFIG_DEBUG_PREEMPT is enabled, if
this is called without preemption disabled.

-- Steve




\
 
 \ /
  Last update: 2012-01-27 18:23    [W:0.156 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site