Messages in this thread | | | Subject | Re: [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface | From | Steven Rostedt <> | Date | Fri, 27 Jan 2012 12:21:39 -0500 |
| |
On Fri, 2012-01-27 at 17:54 +0100, Jiri Olsa wrote:
> yay.. ok :) so this one is triggered only if there's CONFIG_DEBUG_PREEMPT > option enabled.. seems to me it'd better to keep the implicit check anyway.
If the per_cpu pointer usage already warns if preemption is not disabled, then we don't need the extra check. I think I was the one to recommend adding it, but if the warning is already there, I don't think it is necessary. You can still keep a comment, and even say, the per_cpu pointer usage will complain when CONFIG_DEBUG_PREEMPT is enabled, if this is called without preemption disabled.
-- Steve
| |