Messages in this thread | | | Date | Fri, 27 Jan 2012 11:35:02 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH v3 -mm 1/3] mm: reclaim at order 0 when compaction is enabled |
| |
On 01/27/2012 04:13 AM, Hillf Danton wrote:
>> @@ -1195,7 +1195,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, >> BUG(); >> } >> >> - if (!order) >> + if (!sc->order || !(sc->reclaim_mode& RECLAIM_MODE_LUMPYRECLAIM)) >> continue; >> > Just a tiny advice 8-) > > mind to move checking lumpy reclaim out of the loop, > something like
Hehe, I made the change the way it is on request of Mel Gorman :)
I don't particularly care either way and will be happy to make the code whichever way people prefer.
Just let me know.
-- All rights reversed
| |