Messages in this thread | | | Date | Fri, 27 Jan 2012 19:21:18 +0400 | From | Stanislav Kinsbursky <> | Subject | Re: [PATCH 3/4] SUNRPC: service destruction in network namespace context |
| |
27.01.2012 18:33, J. Bruce Fields пишет: > OK, so at this point svc_close_net(serv, current->nsproxy->net_ns) is > enough to clear out sv_permsocks and sv_temp_socks because we know that > the only sockets left are in that namespace. Got it. >
BTW, is this approach looks suitable for NFSd service?
> I'm not sure. The one thing that might have helped mere here would be > a comment to explain what's going on, maybe something like: > > svc_close_net(serv, net); > + /* > + * The last user is gone, so the only sockets left belonged its > + * network namespace: > + */ > BUG_ON(!list_empty(&serv->sv_permsocks)); > BUG_ON(!list_empty(&serv->sv_tempsocks));
Ok, can do so.
-- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |