Messages in this thread | | | Date | Fri, 27 Jan 2012 06:41:27 -0800 (PST) | From | Jakob Bornecrantz <> | Subject | Re: [RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle |
| |
----- Original Message ----- > On 01/27/2012 03:24 PM, Jakob Bornecrantz wrote: > > I was asking around and this seems to only be used by X when it > > starts and we want to preserve the contents of the screen. That > > feature is implemented by the X driver. So we need to figure how we > > want to solve it. > > > > Either way this fix should probably go into this RC series, not > > sure if we need to send this to stable, since we are not leaking > > data to userspace (check drm_mode_getfb), but we might as well. > > > > Reviewed-by: Jakob Bornecrantz<jakob@vmware.com> > > But shouldn't we return the *real* handle. Not 0??
Yeah, you are right. Not sure we have user_handle in the stable kernels tho.
We need to change not only the X driver but also all the other userspace components since at least libkms doesn't create shared buffers. And if the thing that is running before X is using fbdev this wont do much good either since fbdev is not backed by a fb in the way other drivers do it.
Cheers, Jakob.
| |