Messages in this thread | | | Date | Fri, 27 Jan 2012 11:49:20 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86/mce: Replace hard coded hex constants with symbolic defines |
| |
* Tony Luck <tony.luck@intel.com> wrote:
> Magic constants like 0x0134 in code just invite questions on > where they come from, what they mean, can they be changed? > > Provide #defines for the architecturally defined MCACOD values > with a reference to the Intel Software Developers manual which > describes them. > > Signed-off-by: Tony Luck <tony.luck@intel.com> > --- > > Ingo: You said "ok up to 100 cols or so" ... this goes to 103. > If this is OK, you can either apply it from here on top of the > x86/mce branch in tip - or I can push it to the ras tree and > send you another pull.
Yeah, looks good to me.
Thanks,
Ingo
| |