lkml.org 
[lkml]   [2012]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/mce: Replace hard coded hex constants with symbolic defines

* Tony Luck <tony.luck@intel.com> wrote:

> Magic constants like 0x0134 in code just invite questions on
> where they come from, what they mean, can they be changed?
>
> Provide #defines for the architecturally defined MCACOD values
> with a reference to the Intel Software Developers manual which
> describes them.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>
> Ingo: You said "ok up to 100 cols or so" ... this goes to 103.
> If this is OK, you can either apply it from here on top of the
> x86/mce branch in tip - or I can push it to the ras tree and
> send you another pull.

Yeah, looks good to me.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-01-27 11:51    [W:0.034 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site