Messages in this thread | | | Date | Thu, 26 Jan 2012 16:06:30 -0800 | From | David Brown <> | Subject | Re: [PATCH] iommu/msm: Fix error handling in msm_iommu_unmap() |
| |
On Thu, Jan 26, 2012 at 06:29:44PM +0100, Joerg Roedel wrote: > Error handling in msm_iommu_unmap() is broken. On some error > conditions retval is set to a non-zero value which causes > the function to return 'len' at the end. This hides the > error from the user. Zero should be returned in those error > cases. > > Cc: David Brown <davidb@codeaurora.org> > Cc: Stepan Moskovchenko <stepanm@codeaurora.org> > Signed-off-by: Joerg Roedel <joerg.roedel@amd.com> > --- > drivers/iommu/msm_iommu.c | 7 +------ > 1 files changed, 1 insertions(+), 6 deletions(-)
Acked-by: David Brown <davidb@codeaurora.org>
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |