lkml.org 
[lkml]   [2012]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] fs: Invalidate the cache for a parent block-device if fsync() is called for a partition


On Thu, 26 Jan 2012, Christoph Hellwig wrote:

> On Thu, Jan 26, 2012 at 01:40:51PM -0800, Andrew Morton wrote:
> > The Right Thing To Do here is to make the kernel behave logically and
> > predictably, then modify the userspace tools. But if we're modifying
> > the userspace tools then we would just change userspace to issue a
> > BLKFLSBUF to /dev/sda and leave the kernel alone.
>
> The right fix is to make partition and whole disk access coherent,
> which is fairly simply:
>
> - create the block device inode/mapping per gendisk, and only reference
> count it per block_device
> - make sure blkdev_get_block(s) applies the correct offset if used on
> partitions

... and what if you use 4kB blocksize and the partition start is not
aligned on 4kB? (quite common case, because partitions are often aligned
on 63 sectors) Then, you can't translate partition block numbers into disk
block numbers.

Mikulas


\
 
 \ /
  Last update: 2012-01-26 22:53    [W:0.087 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site