Messages in this thread | | | Date | Wed, 25 Jan 2012 00:41:36 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH 1/4] thermal_sys: Remove unnecessary line continuations |
| |
On Tue, 24 Jan 2012, Joe Perches wrote:
> Line continations are not necessary in function calls > or statements. Remove them. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/thermal/thermal_sys.c | 11 +++++------ > 1 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index dd9a574..7326baa 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -283,8 +283,7 @@ passive_show(struct device *dev, struct device_attribute *attr, > static DEVICE_ATTR(type, 0444, type_show, NULL); > static DEVICE_ATTR(temp, 0444, temp_show, NULL); > static DEVICE_ATTR(mode, 0644, mode_show, mode_store); > -static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, \ > - passive_store); > +static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, passive_store); > > static struct device_attribute trip_point_attrs[] = { > __ATTR(trip_point_0_type, 0444, trip_point_type_show, NULL), > @@ -1314,8 +1313,8 @@ int generate_netlink_event(u32 orig, enum events event) > int result; > > /* allocate memory */ > - size = nla_total_size(sizeof(struct thermal_genl_event)) + \ > - nla_total_size(0); > + size = nla_total_size(sizeof(struct thermal_genl_event)) + > + nla_total_size(0); > > skb = genlmsg_new(size, GFP_ATOMIC); > if (!skb) > @@ -1331,8 +1330,8 @@ int generate_netlink_event(u32 orig, enum events event) > } > > /* fill the data */ > - attr = nla_reserve(skb, THERMAL_GENL_ATTR_EVENT, \ > - sizeof(struct thermal_genl_event)); > + attr = nla_reserve(skb, THERMAL_GENL_ATTR_EVENT, > + sizeof(struct thermal_genl_event)); > > if (!attr) { > nlmsg_free(skb); >
Yes. Reviewed-by: Jesper Juhl <jj@chaosbits.net>
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
| |