Messages in this thread | | | Date | Mon, 23 Jan 2012 14:23:55 -0500 (EST) | Subject | Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb | From | David Miller <> |
| |
From: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com> Date: Tue, 24 Jan 2012 00:43:10 +0530
> On Tue, Jan 24, 2012 at 12:23 AM, David Miller <davem@davemloft.net> wrote: >> From: Joe Perches <joe@perches.com> >> Date: Mon, 23 Jan 2012 10:40:34 -0800 >> >>> Perhaps you should break this large patch >>> into multiple separate patches. >> >> Agreed, this patch is way too large especially for what is obviously >> turning out to be a very non-trivial transformation in some cases >> and also new patch submitters should generally avoid large patches >> like this. > > Acked! Will try to separate out trivial & non-trivial changes. > Although, still trivial changes would be big enough. And at the same > time, splitting changes into 118 patches might turn out to be > cumbersome for review.
We didn't say to create 118 patches, we're talking about on the order of 4 or 5 patches.
| |