Messages in this thread | | | Subject | Re: [PATCH] dmaengine/ste_dma40: clear LNK on channel startup | From | Vinod Koul <> | Date | Mon, 02 Jan 2012 16:43:57 +0530 |
| |
On Wed, 2011-12-28 at 11:27 +0530, Narayanan G wrote: > From: Rabin Vincent <rabin.vincent@stericsson.com> > > Otherwise if a previously physical channel is used as a logical channel, the > LNK may have old values which affect the operation of the logical channel since > the LNK register has different semantics between physical and logical channels. > > Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com> > Reviewed-by: Jonas ABERG <jonas.aberg@stericsson.com> > Signed-off-by: Narayanan G <narayanan.gopalakrishnan@stericsson.com> > --- > drivers/dma/ste_dma40.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index 972dc35..cc5ecbc > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -1104,6 +1104,10 @@ static void d40_config_write(struct d40_chan *d40c) > /* Set LIDX for lcla */ > writel(lidx, chanbase + D40_CHAN_REG_SSELT); > writel(lidx, chanbase + D40_CHAN_REG_SDELT); > + > + /* Clear LNK which will be used by d40_chan_has_events() */ > + writel(0, chanbase + D40_CHAN_REG_SSLNK); > + writel(0, chanbase + D40_CHAN_REG_SDLNK); > } > } > Applied, Thanks
-- ~Vinod
| |