Messages in this thread | | | Date | Wed, 18 Jan 2012 22:41:09 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH v3] rtc: ds1307: generalise ram size and offset |
| |
Hi Austin,
> This patch generalises NVRAM to support RAM with other size and offset, such > as the 64 bytes of SRAM on the mcp7941x. > > Signed-off-by: Austin Boyle <Austin.Boyle@aviatnet.com>
I'll pick it up with one minor change:
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
> + if (chip) { > + if (chip->nvram_size) > + ds1307->nvram_size = chip->nvram_size; > + if (chip->nvram_offset) > + ds1307->nvram_offset = chip->nvram_offset;
I'd say we can spare the two ifs above.
> + }
Regards,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |