Messages in this thread | | | Date | Wed, 18 Jan 2012 17:56:14 +0000 | From | Mark Brown <> | Subject | Re: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails. |
| |
On Wed, Jan 18, 2012 at 09:54:27AM -0800, Stephen Warren wrote: > Laxman Dewangan wrote at Wednesday, January 18, 2012 8:17 AM:
> > + .table_len = 73, > > },
> Forgive me if these comments are bogus since I'm not familiar with > regulators much, but:
> a) Don't you want to use ARRAY_SIZE() instead of hard-coding table_len's > value?
> b) Don't you need to set .table to actually point at the table too? If not, > isn't tps65910_list_voltage() going to dereference a NULL pointer, since > it will dereference .table if .table_len is set?
It's not actually a table at all any more as the driver calculates the values, table_len is misnamed and should be renamed as well as set.
| |