Messages in this thread | | | Subject | Re: [PATCH RT 2/4] wait-simple: Simple waitqueue implementation | From | Mike Galbraith <> | Date | Wed, 18 Jan 2012 14:40:17 +0100 |
| |
On Wed, 2012-01-18 at 07:45 -0500, Steven Rostedt wrote: > On Wed, 2012-01-18 at 10:28 +0100, Mike Galbraith wrote: > > > + > > > +void __init_swait_head(struct swait_head *head, struct lock_class_key *key) > > > +{ > > > + raw_spin_lock_init(&head->lock); > > > + lockdep_set_class(&head->lock, key); > > > + INIT_LIST_HEAD(&head->list); > > > +} > > > +EXPORT_SYMBOL_GPL(__init_swait_head); > > > > #include <linux/module.h> ? > > Did it fail to compile for you? The 3.2 version included linux/export.h > which didn't exist, and that failed the compile for me. I removed it an > it compiled fine. But perhaps I should have replaced it with module.h. > I'll look into it.
I saw compiler warning go zinging by, stopped the build and added the include. Trying to use the posted patches doesn't work without digging out the signature damage, so it was easier to make my own.. and I too just spanked the non-existent include :)
-Mike
| |