Messages in this thread | | | Date | Tue, 17 Jan 2012 09:38:43 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] mce: fix warning messages about static struct mce_device |
| |
* Greg KH <gregkh@suse.de> wrote:
> diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h > index f35ce43..6aefb14 100644 > --- a/arch/x86/include/asm/mce.h > +++ b/arch/x86/include/asm/mce.h > @@ -151,7 +151,7 @@ static inline void enable_p5_mce(void) {} > > void mce_setup(struct mce *m); > void mce_log(struct mce *m); > -DECLARE_PER_CPU(struct device, mce_device); > +extern struct device *mce_device[CONFIG_NR_CPUS];
Minor nit, i don't think we have any other such [CONFIG_NR_CPUS] pattern in the kernel.
This should be something like:
DECLARE_PER_CPU(struct device *, mce_device);
Or the pointer should be attached to the CPU info structure.
Thanks,
Ingo
| |