Messages in this thread | | | Subject | Re: [patch v2, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP | From | Eric Dumazet <> | Date | Tue, 17 Jan 2012 09:29:30 +0100 |
| |
Le mardi 17 janvier 2012 à 09:04 +0100, Štefan Gula a écrit : > Dňa 17. januára 2012 5:47, Eric Dumazet <eric.dumazet@gmail.com> napísal/a: > > > > 2) You call ipgre_tap_bridge_fini() from ipgre_exit_net() and > > ipgre_init_net(), thats completely bogus if CONFIG_NET_NS=y > > > > Just remove the struct kmem_cache *ipgre_tap_bridge_cache > > and use instead kmalloc(sizeof(...))/kfree(ptr) instead. > > > As this is completely the same part of code from net/bridge/br_fdb.c, > can you give me a hint about how change that as I believe it should be > changed also there?
Please dont copy code you dont understand :(
bridge code is ok, but not yours, since you destroy the kmem_cache when a net namespace exits.
Either you fix your code, either you change your memory allocations to mere kmalloc()/kfree() calls and dont care of a private kmem_cache you have to create and destroy.
Since you ask a SLAB_HWCACHE_ALIGN, the SLUB allocator will anyway merge your kmem_cache with the standard one (kmalloc-64 I guess)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |