lkml.org 
[lkml]   [2012]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface
On Mon, Jan 16, 2012 at 09:07:35PM -0500, Steven Rostedt wrote:
> On Tue, 2012-01-17 at 02:42 +0100, Frederic Weisbecker wrote:
> >
> > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> > > index 523640f..0d43a2b 100644
> > > --- a/include/linux/ftrace.h
> > > +++ b/include/linux/ftrace.h
> > > @@ -35,12 +35,14 @@ enum {
> > > FTRACE_OPS_FL_ENABLED = 1 << 0,
> > > FTRACE_OPS_FL_GLOBAL = 1 << 1,
> > > FTRACE_OPS_FL_DYNAMIC = 1 << 2,
> > > + FTRACE_OPS_FL_CONTROL = 1 << 3,
> >
> > Please comment the role of this flag. In fact it would be nice to have
> > a comment that explains all these. GLOBAL and DYNAMIC don't actually give
> > much clues alone.
>
> Someone else asked about commenting these (was it you?).

Probably, as I asked you the meaning of that GLOBAL on irc :)

> I probably should, as it is confusing to what they are used for.

Yeah that would be nice.

> I just figured every just figures it out by looking at the code ;-)

That's often what happens when the reader of the code is also the writer :)
Also, there is no user that doesn't have FTRACE_OPS_FL_GLOBAL yet, so
it's hard to find a counter example.


\
 
 \ /
  Last update: 2012-01-17 03:31    [W:0.162 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site