Messages in this thread | | | From | Štefan Gula <> | Date | Mon, 16 Jan 2012 16:20:05 +0100 | Subject | Re: [patch v1, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP |
| |
Dňa 16. januára 2012 16:13, Eric Dumazet <eric.dumazet@gmail.com> napísal/a: > Le lundi 16 janvier 2012 à 15:47 +0100, Štefan Gula a écrit : > >> File: net/birdge/br_fdb.c >> Functions: >> __br_fdb_get >> br_fdb_get >> My analogy fuctions: >> __ipgre_tap_bridge_get >> ipgre_tap_bridge_get >> > > There is no br_fdb_get(), you copied some buggy code I am afraid. > > Read again your patch. > > If you use atomic_inc_not_zero(&x->use_count), then you must do the > atomic_dec() or leak entries. > > Current bridge code doesnt use atomic_inc_not_zero() > > > You are right, new bridge code doesn't have such function, I will adjust that -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |