Messages in this thread | | | Date | Sun, 15 Jan 2012 16:04:10 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH] KVM: MMU: increment stats after event occurrence |
| |
On 01/13/2012 02:56 PM, Davidlohr Bueso wrote: > On Fri, 2012-01-13 at 10:24 +0900, Takuya Yoshikawa wrote: > > (2012/01/13 10:08), Davidlohr Bueso wrote: > > > From: Davidlohr Bueso<dave@gnu.org> > > > > > > It makes more sense to actually increment statistics for tlb flushes and page table entry updates after such _events_ occur, instead of before. > > > > Why? > > > From a logical point of view its better to increase stats once the event > is processed - usually because it can fail and therefore the stats would > be incorrect. >
That doesn't hold for the cases you change.
-- error compiling committee.c: too many arguments to function
| |