Messages in this thread | | | Date | Sat, 14 Jan 2012 08:48:07 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: x86/mce: machine check warning during poweroff |
| |
On 01/14/2012 08:40 AM, Linus Torvalds wrote:
> On Fri, Jan 13, 2012 at 7:05 PM, Srivatsa S. Bhat > <srivatsa.bhat@linux.vnet.ibm.com> wrote: >>> On Fri, Jan 13, 2012 at 6:41 PM, Srivatsa S. Bhat >>> <srivatsa.bhat@linux.vnet.ibm.com> wrote: >>> >>>> The patch below works perfectly for me - I tested multiple CPU hotplug >>>> operations as well as multiple pm_test runs at core level. Please let me >>>> know if this solves the suspend issue as well.. >>> >>> Ok, I'll try, and I bet it does. > > Yup, I can suspend and resume multiple times now.
Wow! Feels good to hear that, at last! :-)
By the way, in my excitement, while sending the patch I forgot to give credits to the problem reporters with a "Reported-by". Hope that gets resolved.
> >> I totally agree with you. Even I had set out to find out *exactly* what >> was going wrong. After spending significant amount of time digging through >> the code (unsuccessfully), this idea of zeroing out everything struck me >> and it worked, as expected. Yes, it is definitely important to know the >> exact issue so that we can fix the driver core and avoid other mishaps, >> but I guess finding that out is not all that simple.. as of now I am >> rather exhausted following those zillions of pointers continuously >> for the past few hours.. ;-/ > > Fair enough. The many layers of clever indirection are really really > nasty to follow, I agree. >
:-)
Regards, Srivatsa S. Bhat IBM Linux Technology Center
| |