lkml.org 
[lkml]   [2012]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 3.2.0-rc5 9/9] perf: perf interface for uprobes
Hi Srikar,

(2012/01/09 20:24), Srikar Dronamraju wrote:
>>
>>> +
>>> +static int convert_to_perf_probe_point(struct probe_trace_point *tp,
>>> + struct perf_probe_point *pp)
>>> +{
>>> + pp->function = strdup(tp->symbol);
>>> + if (pp->function == NULL)
>>> + return -ENOMEM;
>>> + pp->offset = tp->offset;
>>> + pp->retprobe = tp->retprobe;
>>> +
>>> + return 0;
>>> +}
>>
>> This function could be used in kprobe_convert_to_perf_probe() too.
>> In that case, it will be separated as a cleanup from this.
>
> Do you really want this in a separate patch, since it doesnt make too
> much sense without the uprobes code.

If so, breaking this big patch into small pieces helps
(at least) me to review/maintain the change :)

Thank you,

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


\
 
 \ /
  Last update: 2012-01-12 15:53    [W:0.076 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site