Messages in this thread | | | Date | Sun, 1 Jan 2012 23:49:09 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH 1/1] via-rhine: Split driver into .c and .h files. |
| |
Bjarke Istrup Pedersen <gurligebis@gentoo.org> : > Split the driver into via-rhine.c and via-rhine.h like it should be. > There is also a bit of cleanup of checkpatch warnings, other than that, > there is no changes to how the code works, it is plain refactoring.
Please don't do that. The .h won't be used elsewhere. It's useless (and register definitions stay barely readable).
Roger, any comment regarding patches #1 .. #3 ?
rhine_task_{enable / disable} should be balanced in open / close and suspend / resume, ok.
-- Ueimor
| |