Messages in this thread | | | Date | Thu, 29 Sep 2011 17:33:42 -0600 | From | David Ahern <> | Subject | Re: [PATCH] perf tools: Exit recording if events have non matching sample type |
| |
On 09/29/2011 05:06 PM, Arnaldo Carvalho de Melo wrote: >> >From what I can see sample_type has to be the same for all samples: >> https://lkml.org/lkml/2011/8/15/6 > > We could add a PERF_SAMPLE_ID2 that if present would be guaranteed to be > the last, or we can, as PeterZ prefers/suggests, to use one mmap per > sample id, then we know that if we're getting it on that mmap, it has > that sample_type. > > For record that means we need to dump each per-sample_id mmap onto a > separate file, i.e. use a directory, etc.
That seems like a major re-write of perf. Why not keep the existing restriction and have users who want different sample_types run multiple perf commands?
What's to be gained by refactoring the code to support multiple sample_types in a single command invocation?
David
| |