Messages in this thread | | | Date | Wed, 10 Aug 2011 11:22:49 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages() |
| |
On Wed, Aug 10, 2011 at 02:41:05AM +0800, Peter Zijlstra wrote: > On Tue, 2011-08-09 at 14:15 -0400, Vivek Goyal wrote: > > > > So far bw had pos_ratio as value now it will be replaced with actual > > bandwidth as value. It makes code confusing. So using pos_ratio will > > help. > > Agreed on consistency, also I'm not sure bandwidth is the right term > here to begin with, its a pages/s unit and I think rate would be better > here. But whatever ;-)
Good idea, I'll switch to the name "rate".
Thanks, Fengguang
| |