lkml.org 
[lkml]   [2011]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: tps6586x: add SMx slew rate setting
On Fri, Aug 05, 2011 at 07:51:15PM +0800, Danny Huang wrote:
> Thanks for the feedback.
> The reason for using driver_data is that I can't find a proper field in regulator_init_data for the slew rate setting.
> I'll do some correction based on the feedback and try to add a new field for the slew rate setting.

No, this is OK - we should really rename the driver_data field, it's
very misleading. However:

> + return tps6586x_write(parent, reg, setting->slew_rate);

what happens if the user sets zero for the slew rate (eg, if another
field is added to the platform data that they want to set)? Is this a
sane setting (like the chip default) or might it break something?


\
 
 \ /
  Last update: 2011-08-08 11:39    [W:0.113 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site