Messages in this thread | | | Date | Mon, 8 Aug 2011 18:37:05 +0900 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: tps6586x: add SMx slew rate setting |
| |
On Fri, Aug 05, 2011 at 07:51:15PM +0800, Danny Huang wrote: > Thanks for the feedback. > The reason for using driver_data is that I can't find a proper field in regulator_init_data for the slew rate setting. > I'll do some correction based on the feedback and try to add a new field for the slew rate setting.
No, this is OK - we should really rename the driver_data field, it's very misleading. However:
> + return tps6586x_write(parent, reg, setting->slew_rate);
what happens if the user sets zero for the slew rate (eg, if another field is added to the platform data that they want to set)? Is this a sane setting (like the chip default) or might it break something?
| |