Messages in this thread | | | From | Grant Likely <> | Date | Mon, 8 Aug 2011 12:24:50 -0600 | Subject | Re: [PATCH] GPIOLIB: add generic gpio_set_pull API |
| |
On Mon, Aug 8, 2011 at 2:15 AM, Paul Mundt <lethal@linux-sh.org> wrote: > On Sun, Aug 07, 2011 at 10:19:33PM -0700, Barry Song wrote: >> Now there are many different implementations for GPIO pull configuration, for >> example: >> s3c_gpio_setpull() >> tegra_pinmux_set_pullupdown() >> chipcHw_setPinPullup() >> gpio_pullup() >> s3c2410_gpio_pullup() >> >> This patch adds a new generic gpio_set_pull API so that all SoCs can have unified >> codes. >> >> Signed-off-by: Barry Song <Baohua.Song@csr.com> > > For arch/arm/mach-shmobile we also have gpio_pull_up() for board-g4evm.c > and gpio_pull_down() for board-mackerel.c. Both of these would benefit > from this sort of an API addition.
I think I'm okay with this API change. Linus, what say you? How does this interact with your plans for pinctrl?
g.
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.
| |