lkml.org 
[lkml]   [2011]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[33/50] geode: reflect mfgpt dependency on mfd
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: "Philip A. Prindeville" <philipp@redfish-solutions.com>

    commit 703f03c896fdbd726b809066ae279df513992f0e upstream.

    As stated in drivers/mfd/cs5535-mfd.c, the mfd driver exposes the BARs
    which then make the GPIO, MFGPT, ACPI, etc. all visible to the system.

    So the dependencies of the MFGPT stuff have changed, and most people
    expect Kconfig to bring in the necessary dependencies. Without them, the
    module fails to load and most people don't understand why because the
    details of the rewrite aren't captured anywhere most people who know to
    look.

    This dependency needs to be reflected in Kconfig.

    Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
    Acked-by: Alexandros C. Couloumbis <alex@ozo.com>
    Acked-by: Andres Salomon <dilinger@queued.net>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/misc/Kconfig | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/misc/Kconfig
    +++ b/drivers/misc/Kconfig
    @@ -189,8 +189,7 @@ config SGI_XP

    config CS5535_MFGPT
    tristate "CS5535/CS5536 Geode Multi-Function General Purpose Timer (MFGPT) support"
    - depends on PCI
    - depends on X86
    + depends on PCI && X86 && MFD_CS5535
    default n
    help
    This driver provides access to MFGPT functionality for other



    \
     
     \ /
      Last update: 2011-08-06 02:17    [W:2.645 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site