lkml.org 
[lkml]   [2011]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH/RFC] cap_syslog: make CAP_SYS_ADMIN deprecation notice less alarming
On Wed, Aug 3, 2011 at 6:48 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>
> Convert the WARN_ONCE to a printk_once to avoid this while continuing
> to give userspace developers a hint that this is an unwanted
> backward-compatibility feature and won't be around forever.

The problem with this one is that converting away from a warning
doesn't just get rid of all the ugliness, it gets rid of some of the
*useful* information in the warning too.

In particular, when you have a warning like "Attempting to access
syslog", you'd better tell people *who* is attempting to access
syslog, so that they can fix it or complain to the right person.

And the warning does show what process it is (in addition to
stacktrace, tainting etc that we don't want). Your printk_once()
conversion does not.

Linus


\
 
 \ /
  Last update: 2011-08-05 20:53    [W:0.142 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site