Messages in this thread | | | Subject | Re: [PATCH] hwmon: add caseopen detection to w83627ehf driver | From | Guenter Roeck <> | Date | Fri, 5 Aug 2011 09:55:50 -0700 |
| |
On Fri, 2011-08-05 at 09:00 -0400, Dmitry Artamonow wrote: > Export caseopen alarm status into userspace for > Winbond w83627* chips and also implement alarm clear knob. > > Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
[ ... ]
> +static ssize_t > +store_caseopen_clear(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count)
Another note: Please drop the "_clear" from the function name. It is redundant with "store_". Another possible name would be "clear_caseopen".
Thanks, Guenter
| |