lkml.org 
[lkml]   [2011]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v3.1 0/3] x86, AMD: Correct F15h IC aliasing issue
On 08/05/2011 06:15 AM, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Hi,
>
> a small refinement of the patchset from yesterday per hpa's comments:
>
> * put mask and flags into a single cacheline and make it __read_mostly
>
> * change alignment computation back to clearing bits [14:12] so that a
> mask of 0x0 can have no effect on the address.
>
> Please take a look and apply, if no objections.
>

Patch 1 looks good now.

Patch 2 I'm going to object to because it puts your run_on_bsp method
into a different structure where all the existing methods for this
already are in a way that looks totally gratuitous to me. Why not just
have a c_bsp_init on struct cpu_dev like all the other methods?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2011-08-05 19:13    [W:0.156 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site