Messages in this thread | | | Date | Thu, 4 Aug 2011 21:50:57 -0400 | From | Dave Jones <> | Subject | Re: [rfc] suppress excessive AER output |
| |
On Thu, Aug 04, 2011 at 02:45:01PM +0800, huang ying wrote: > On Thu, Aug 4, 2011 at 6:34 AM, Dave Jones <davej@redhat.com> wrote: > > I have a machine that has developed some kind of problem with > > its onboard ethernet. It still boots, but spewed almost 1.5G of text > > (2381585 instances of the warning below) before we realised what > > was going on, and blacklisted the igb driver. > > > > Is it worth logging every single error when we're flooding like this ? > > It seems unlikely that we'll find useful information in amongst that much data > > that wasn't already in the first 100 instances. > > > > I picked 100 in the (untested) example patch below arbitarily, but the exact > > value could be smaller, or slightly bigger.. > > > > could we do something like this maybe ? > > Why not use __ratelimit to implement this feature?
that would be better than the current situation probably, but my gut feeling is that there's still going to be a lot of spew.
Dave
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |