Messages in this thread Patch in this message | | | From | "Nandigama, Nagalakshmi" <> | Date | Thu, 4 Aug 2011 12:24:50 +0530 | Subject | RE: [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON |
| |
The patch seem to be fine. Please consider this patch as an Acked by me
Regards, Nagalakshmi
-----Original Message----- From: Julia Lawall [mailto:julia@diku.dk] Sent: Tuesday, August 02, 2011 4:05 PM To: Moore, Eric; trivial@kernel.org Cc: kernel-janitors@vger.kernel.org; Support; DL-MPT Fusion Linux; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON
From: Julia Lawall <julia@diku.dk>
Use BUG_ON(x) rather than if(x) BUG();
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ identifier x; @@ -if (x) BUG(); +BUG_ON(x);
@@ identifier x; @@ -if (!x) BUG(); +BUG_ON(!x); // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/message/fusion/mptsas.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c --- a/drivers/message/fusion/mptsas.c +++ b/drivers/message/fusion/mptsas.c @@ -3410,8 +3410,7 @@ mptsas_expander_event_add(MPT_ADAPTER *i __le64 sas_address; port_info = kzalloc(sizeof(struct mptsas_portinfo), GFP_KERNEL); - if (!port_info) - BUG(); + BUG_ON(!port_info); port_info->num_phys = (expander_data->NumPhys) ? expander_data->NumPhys : 1; port_info->phy_info = kcalloc(port_info->num_phys,
| |