Messages in this thread | | | Date | Thu, 4 Aug 2011 12:39:54 +0200 | From | Jan Kara <> | Subject | Re: [PATCH 2/4] fs/ext2/balloc.c: delete useless initialization |
| |
On Thu 04-08-11 12:29:32, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Delete nontrivial initialization that is immediately overwritten by the > result of an allocation function. Thanks. Merged.
Honza > > The semantic match that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > type T; > identifier i; > expression e; > @@ > > ( > T i = \(0\|NULL\|ERR_PTR(...)\); > | > -T i = e; > +T i; > ) > ... when != i > i = \(kzalloc\|kcalloc\|kmalloc\)(...); > > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > fs/ext2/balloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/fs/ext2/balloc.c b/fs/ext2/balloc.c > --- a/fs/ext2/balloc.c > +++ b/fs/ext2/balloc.c > @@ -421,7 +421,7 @@ static inline int rsv_is_empty(struct ex > void ext2_init_block_alloc_info(struct inode *inode) > { > struct ext2_inode_info *ei = EXT2_I(inode); > - struct ext2_block_alloc_info *block_i = ei->i_block_alloc_info; > + struct ext2_block_alloc_info *block_i; > struct super_block *sb = inode->i_sb; > > block_i = kmalloc(sizeof(*block_i), GFP_NOFS); > -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |