lkml.org 
[lkml]   [2011]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 3/3] r8169: support new chips of RTL8111F
Hayes Wang <hayeswang@realtek.com> :
[...]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 68f1e2f..c04fbc0 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
[...]
> @@ -4476,6 +4602,49 @@ static void rtl_hw_start_8168e_2(void __iomem *ioaddr, struct pci_dev *pdev)
> RTL_W8(Config5, RTL_R8(Config5) & ~Spi_en);
> }
>
> +static void rtl_hw_start_8168f_1(void __iomem *ioaddr, struct pci_dev *pdev)
[...]
> + RTL_W8(MaxTxPacketSize, 0x27);

Hmmm...

$ grep MaxTxPacketSize drivers/net/r8169.c
MaxTxPacketSize = 0xec, /* 8101/8168. Unit of 128 bytes. */
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, 0x27);
RTL_W8(MaxTxPacketSize, TxPacketMax);
RTL_W8(MaxTxPacketSize, TxPacketMax);

Is the 0x27 value still in units of 128 bytes ?

Could it be TxPacketMax as everywhere else in the driver instead of 0x27 ?

--
Ueimor


\
 
 \ /
  Last update: 2011-08-31 22:19    [W:0.056 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site