lkml.org 
[lkml]   [2011]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH V8 4/4] mm: frontswap: config and doc files
> From: Valdis.Kletnieks@vt.edu [mailto:Valdis.Kletnieks@vt.edu]
> Subject: Re: [PATCH V8 4/4] mm: frontswap: config and doc files
>
> On Mon, 29 Aug 2011 09:49:49 PDT, Dan Magenheimer said:
>
> > --- linux/mm/Kconfig 2011-08-08 08:19:26.303686905 -0600
> > +++ frontswap/mm/Kconfig 2011-08-29 09:52:14.308745832 -0600
> > @@ -370,3 +370,20 @@ config CLEANCACHE
> > in a negligible performance hit.
> >
> > If unsure, say Y to enable cleancache
> > +
> > +config FRONTSWAP
> > + bool "Enable frontswap to cache swap pages if tmem is present"
> > + depends on SWAP
> > + default n
>
> > +
> > + If unsure, say Y to enable frontswap.
>
> Am I the only guy who gets irked when the "default" doesn't match the
> "If unsure" suggestion? :) (and yes, I know we have guidelines for
> what the "default" should be...)

Hi Valdis --

Thanks for the review!

Count me as irked. The default should be "y" because the
overhead is extremely tiny when not enabled at runtime by
a backend (though admittedly non-zero), but I got flamed by
Linus last time I tried that (for cleancache), so I'm not
going to try it for frontswap! :-) The "if unsure" is the
best I can do for now to encourage distros to enable it.

Dan


\
 
 \ /
  Last update: 2011-08-31 01:17    [W:1.114 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site